Apply #195 + suggested fixes #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/valeria/update-insolation
branch
from
6dfa95c
to
1059d44
Compare
|
@charleskawczynski is this PR still planned? |
|
Ah, yes, we should revive this if insolation hasn’t been updated yet. I’ll see if I can rebase tomorrow |
no rush! just doing a little housekeeping over here :) |
|
@charleskawczynski Is it okay to close this PR? I'm not sure what the suggested fixes in addition to #195 are |
|
@charleskawczynski is this something you would like me to finish (do we still need it?) |
|
superseded by #407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies #195 and applies the suggested fixes.