Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloudy aquaplanet driver #811

Merged
merged 1 commit into from
May 25, 2024
Merged

Add cloudy aquaplanet driver #811

merged 1 commit into from
May 25, 2024

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented May 23, 2024 •
edited
Loading

closes #762

  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak marked this pull request as ready for review May 23, 2024 18:13
juliasloan25
juliasloan25 approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! After adding a brief summary to the top of the driver, it's good to go :)

@LenkaNovak
init
ea1cd58 
hier pip

turn off diff

100s

6 helems, 30 z, 120s

revert to init, albedo

format

pip

format

rev

rebase fix
@LenkaNovak LenkaNovak enabled auto-merge May 24, 2024 23:40
@LenkaNovak LenkaNovak merged commit b50c102 into main May 25, 2024
7 checks passed
@juliasloan25 juliasloan25 deleted the ln/cloudy_aqua branch May 25, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliasloan25 juliasloan25 juliasloan25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hierarchies: Cloudy aquaplanet driver
2 participants
@LenkaNovak @juliasloan25