Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add amip requirements to docs #681

Closed
wants to merge 1 commit into from
Closed

add amip requirements to docs #681

wants to merge 1 commit into from

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Mar 7, 2024

Purpose

Closes #652

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21
Copy link
Member Author

szy21 commented Mar 7, 2024

@juliasloan25 @LenkaNovak Here is a draft of a brief amip description. I wonder:

  1. Would you like it to be more detailed?
  2. Would you like to have references?
  3. For components with None, would you like them to be removed?

Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, Zhaoyi! Now that I see the details, this might fit better in the experiments/AMIP/README.md file since that's where the AMIP driver lives and the coupler supports other setups too.

docs/src/index.md Show resolved Hide resolved
docs/src/index.md Show resolved Hide resolved
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you, @szy21 !

Shall we add more details on insolation and EDMF? I've been notionally thinking something like this, but maybe being somewhat less specific on the details that are changing is fine. :)

@juliasloan25
Copy link
Member

to answer your questions...

Would you like it to be more detailed?
Would you like to have references?
For components with None, would you like them to be removed?

  1. I think the detail level is good, but I'm less familiar with the physics so will default to you two on that
  2. References would be nice if possible, but if we don't have them it's okay too
  3. To me it seems like it's good to keep "none" for components we don't have so it's clear what is and isn't included

@szy21 szy21 marked this pull request as ready for review March 13, 2024 01:11
@szy21
Copy link
Member Author

szy21 commented Mar 13, 2024

hmm for some reason my branch is updated but this PR is not. I'll try close and reopen.

@szy21 szy21 closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add checklist of AMIP requirements to docs
3 participants