-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add target AMIP runs on GPU #632
Conversation
09828af
to
756232a
Compare
94336e4
to
2ea7a56
Compare
58fea36
to
09f04e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you, @juliasloan25. Just a couple of comments. It would be good to increase the t_end
s in the long runs, but we can do that later. I've triggered a long run here to see where we get, but we can merge this PR for now.
09f04e3
to
e169b3c
Compare
that longrun is actually for a different branch where I'm trying DYAMOND on GPU, but I started a longrun for this branch here |
e169b3c
to
db275dd
Compare
db275dd
to
6a32cda
Compare
Purpose
closes #630
Content
config/longrun_configs/amip_target_topo.yml
anim:false
(not gpu-compatible)config/longrun_configs/amip_target_topo_diagedmf.yml
anim:false
(not gpu-compatible)config/model_configs/gpu_target_amip_albedo_function.yml
->config/model_configs/gpu_amip_albedo_function.yml
to reduce confusion with target GPU AMIP runsupdate_field!
method for co2 (replace(...)[1]
withmean(...)
)