-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use refs for long variable names #627
Conversation
5e44b4a
to
770b4ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, thank you Anastasia! I just left a couple of suggestions. After you address those, you can re-request my review and it should be good to go :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you, @anastasia-popova! I only had a few minor comments.
36ec68b
to
444dd7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! You can rebase on main and then if Lenka approves you can merge :)
9b0c2bd
to
05077a2
Compare
9257893
to
a5780ed
Compare
Purpose
Cleans up long variable names found in experiments/AMIP and src
closes #234
To-do
Content
-Found long variable names in experiments/AMIP and src
-Locally renamed with refs
-Verified that there is no change through bit wise comparison