Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional atmos diagnostics #616

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Additional atmos diagnostics #616

merged 1 commit into from
Feb 13, 2024

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Feb 13, 2024 •
edited
Loading

closes #617

  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak marked this pull request as ready for review February 13, 2024 18:02
juliasloan25
juliasloan25 reviewed Feb 13, 2024
View reviewed changes
experiments/AMIP/components/atmosphere/climaatmos_extra_diags.jl

import ClimaAtmos.Diagnostics: add_diagnostic_variable!

add_diagnostic_variable!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how/where are these meant to be used? a little more explanation in a docstring would be nice :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exercised in the buildkite job slabplanet_atmos_diags, and I've added more info on where in Atmos this is being called.

@LenkaNovak
runs test
24f9bc8 
add physical diags

format

add more comments

space after docstring
@LenkaNovak LenkaNovak merged commit a401c66 into main Feb 13, 2024
9 checks passed
@juliasloan25 juliasloan25 deleted the ln/add-atmos-diag branch March 14, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliasloan25 juliasloan25 juliasloan25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional atmos diagnostics
2 participants
@LenkaNovak @juliasloan25