Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated function calls #612

Merged
merged 1 commit into from
Feb 10, 2024
Merged

remove deprecated function calls #612

merged 1 commit into from
Feb 10, 2024

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Feb 9, 2024 •
edited
Loading

Purpose

closes #611

  • no behavioral changes

To-do

  • update deprecated ClimaCore functions
  • update deprecated ClimaAtmos function

@juliasloan25 juliasloan25 self-assigned this Feb 9, 2024
@juliasloan25 juliasloan25 requested review from LenkaNovak and Sbozzolo and removed request for LenkaNovak February 9, 2024 23:31
@Sbozzolo
Copy link
Member

Sbozzolo commented Feb 9, 2024

note: still seeing Warning: @add_arg_table is deprecated, use @add_arg_table! instead after changes, not sure why

Because of Atmos

Sbozzolo
Sbozzolo approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a space.vertical_topology in Regridder.jl.

I wouldn't be surprised if other things were missed: it's hard to find them all. I guess those will surface at some point.

@juliasloan25
Copy link
Member Author

There's a space.vertical_topology in Regridder.jl.

I only find the one that's fixed in this PR

@Sbozzolo
Copy link
Member

Sbozzolo commented Feb 9, 2024

There's a space.vertical_topology in Regridder.jl.

I only find the one that's fixed in this PR

Yes, I missed it!

@juliasloan25 juliasloan25 merged commit b88dcb8 into main Feb 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees

@juliasloan25 juliasloan25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove deprecated function calls
2 participants
@juliasloan25 @Sbozzolo