Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PythonPlot for test plots #582

Closed
wants to merge 1 commit into from
Closed

use PythonPlot for test plots #582

wants to merge 1 commit into from

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Jan 31, 2024

Purpose

The conservation checker plots are currently failing on MacOS due to an incompatibility with the GR backend introduced in Plots.jl v1.40.0. This PR works around that bug by replacing the GR backend with PythonPlot for this test.

@juliasloan25 juliasloan25 self-assigned this Jan 31, 2024
@juliasloan25 juliasloan25 added the bug Something isn't working label Jan 31, 2024
@juliasloan25 juliasloan25 mentioned this pull request Jan 31, 2024
1 task
@Sbozzolo
Copy link
Member

Can GR be removed?

@juliasloan25
Copy link
Member Author

juliasloan25 commented Jan 31, 2024

Can GR be removed?

PythonPlot is only being used in test so we still need GR in the other envs (it's in experiments/AMIP and perf). I don't see GR in test/Project.toml so I think it's removed there. Though I'm not sure why I had to add PythonPlot explicitly if we didn't do that with GR before. If I remove it and run the tests I get:

LoadError: ArgumentError: Package PythonPlot not found in current path.
Run import Pkg; Pkg.add("PythonPlot") to install the PythonPlot package.

@Sbozzolo
Copy link
Member

Sbozzolo commented Jan 31, 2024

Can GR be removed?

PythonPlot is only being used in test so we still need GR in the other envs (it's in experiments/AMIP and perf). I don't see GR in test/Project.toml so I think it's removed there. Though I'm not sure why I had to add PythonPlot explicitly if we didn't do that with GR before. If I remove it and run the tests I get:

LoadError: ArgumentError: Package PythonPlot not found in current path.
Run import Pkg; Pkg.add("PythonPlot") to install the PythonPlot package.

If GR is incompatible with the latest MacOS, we should use PythonPlot everywhere. I am guessing you have to add PythonPlot but not GR because GR is the default backend (you can see that it is a required dependency in the Project.toml

@juliasloan25
Copy link
Member Author

bug is fixed by GR v0.73.2 (won't merge this)

@juliasloan25 juliasloan25 reopened this Jan 31, 2024
@juliasloan25 juliasloan25 deleted the js/pyplots branch January 31, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants