Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename dt_save_to_disk to dt_save_state_to_disk #564

Merged
merged 1 commit into from
Jan 20, 2024
Merged

rename dt_save_to_disk to dt_save_state_to_disk #564

merged 1 commit into from
Jan 20, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Jan 19, 2024

Purpose

Following recent changes in ClimaAtmos.

To-do

Content


  • I have read and checked the items on the review checklist.

Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are two other files that need to be updated: config/longrun_configs/amip_target_topo.yml and amip_target.yml

@szy21
Copy link
Member Author

szy21 commented Jan 19, 2024

I think there are two other files that need to be updated: config/longrun_configs/amip_target_topo.yml and amip_target.yml

Thanks! I have fixed them.

@szy21 szy21 enabled auto-merge January 19, 2024 18:27
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In case you're using it, the parsed args in local_checks.sh do not take precedence over the config files, so the arguments here may need to be refactored into the relevant yml config files.

@szy21
Copy link
Member Author

szy21 commented Jan 20, 2024

LGTM. In case you're using it, the parsed args in local_checks.sh do not take precedence over the config files, so the arguments here may need to be refactored into the relevant yml config files.

Good to know, thanks!

@szy21 szy21 merged commit e4ca35d into main Jan 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants