Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm modular/ #541

Merged
merged 1 commit into from
Jan 4, 2024
Merged

rm modular/ #541

merged 1 commit into from
Jan 4, 2024

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Dec 14, 2023

Purpose

rename experiments/AMIP/modular/ --> experiments/AMIP/

closes #525

Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @juliasloan25, thank you! All Buildkite runs produce the expected output, except the time out of the MPI run (I presume it was cancelled manually, but lmk if there is some new overarching issue). As a side note, perhaps as part of a separate PR, it would be good to add your convective sea breeze plots to the CI run as a reference.

@juliasloan25
Copy link
Member Author

All Buildkite runs produce the expected output, except the time out of the MPI run (I presume it was cancelled manually, but lmk if there is some new overarching issue).

MPI AMIP has been failing pretty regularly, as documented in #538. I'm in the process of looking into it to figure out what's causing this.

@juliasloan25
Copy link
Member Author

As a side note, perhaps as part of a separate PR, it would be good to add your convective sea breeze plots to the CI run as a reference.

I opened a PR #544 to add the seabreeze plots to buildkite :)

@juliasloan25 juliasloan25 merged commit 26af6c3 into main Jan 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename AMIP/modular/ -> AMIP/
2 participants