remove OrdinaryDiffEq, DiffEqBase #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/rm-ode2
branch
from
56403c1
to
a59004b
Compare
juliasloan25
force-pushed
the
js/rm-ode2
branch
2 times, most recently
from
cc16458
to
55836fa
Compare
Sbozzolo
reviewed
Dec 1, 2023
juliasloan25
force-pushed
the
js/rm-ode2
branch
from
55836fa
to
7a03bde
Compare
juliasloan25
force-pushed
the
js/rm-ode2
branch
from
7a03bde
to
fc095e5
Compare
Sbozzolo
approved these changes
Dec 1, 2023
juliasloan25
force-pushed
the
js/rm-ode2
branch
2 times, most recently
from
4938833
to
de69ba5
Compare
juliasloan25
force-pushed
the
js/rm-ode2
branch
from
de69ba5
to
2ed491e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replace ODE and DiffEqBase dependencies with SciMLBase. We expect this to decrease our precompilation time
Note
We have one test for eisenman sea ice that requires us to add SciMLBase and ClimaTimeSteppers to the
test/environment. I would rather remove this test fromtest/and just rely on this sea ice stepping being tested inexperiments/AMIP. If it isn't currently being tested in our experiments CI, we should add a test case for it.replaces #430
closes #437
To Do
SciMLBase = "1, 2"compat