-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps: use ClimaAtmos 0.15.2 #345
Conversation
5afe2ed
to
d76b3ed
Compare
CI passes and this PR is ready for review. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had a few comments about duplicated compat entries in the top level as well as subdirectories. It might be easier to maintain the dependencies in the future if we just have these specified in the top level, but up to you. I opened an issue about this a couple weeks ago in case it's something we want to change #341
b7f7119
to
cb6330c
Compare
Okay. I have applied all suggestions and rebased. Please let me know if approved, we can merge it. Thanks guys! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had a couple comments about the ClimaComms compats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you, Valeria :)
bors r+ |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Purpose
This PR updates ClimaCoupler to use the latest dependecies. Including:
Closes #344
Closes #341
Content
experiments/AMIP/modular
,test/
,perf/
Project.toml
filesManifest.toml
filesReview checklist
I have:
In the Content, I have included