Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps: use ClimaAtmos 0.15.2 #345

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Update deps: use ClimaAtmos 0.15.2 #345

merged 2 commits into from
Jul 15, 2023

Conversation

valeriabarra
Copy link
Member

@valeriabarra valeriabarra commented Jul 12, 2023

Purpose

This PR updates ClimaCoupler to use the latest dependecies. Including:

  • ClimaLSM v0.2.6
  • ClimaComms v0.5.3
  • ClimaCore v0.10.43
  • ClimaAtmos v0.15.2

Closes #344
Closes #341

Content

  • Updated top-level and experiments/AMIP/modular, test/, perf/ Project.toml files
  • Updated checked-in Manifest.toml files
  • Updated ClimaAtmos CLI options
  • Updated both regular and longrun pipelines with current CLI options
  • Removed compat entries that were duplicated between the top-level environment and the lower-level ones

Review checklist

I have:

In the Content, I have included

  • relevant unit tests, and integration tests,
  • appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

  • I have read and checked the items on the review checklist.

@valeriabarra
Copy link
Member Author

CI passes and this PR is ready for review. Thanks

Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a few comments about duplicated compat entries in the top level as well as subdirectories. It might be easier to maintain the dependencies in the future if we just have these specified in the top level, but up to you. I opened an issue about this a couple weeks ago in case it's something we want to change #341

.buildkite/pipeline.yml Outdated Show resolved Hide resolved
experiments/AMIP/modular/Project.toml Outdated Show resolved Hide resolved
perf/Project.toml Outdated Show resolved Hide resolved
@valeriabarra
Copy link
Member Author

Okay. I have applied all suggestions and rebased. Please let me know if approved, we can merge it. Thanks guys!

Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a couple comments about the ClimaComms compats

Project.toml Show resolved Hide resolved
experiments/AMIP/modular/Project.toml Outdated Show resolved Hide resolved
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you, Valeria :)

@valeriabarra
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 15, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 4a6c573 into main Jul 15, 2023
6 checks passed
@bors bors bot deleted the valeria/atmos-0.15.2 branch July 15, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to ClimaAtmos v0.15.2 Clean up compat entries
3 participants