Update to ClimaAtmos v0.15.1 #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
2 tasks
bors bot
added a commit
to CliMA/ClimaLand.jl
that referenced
this pull request
May 16, 2023
195: Update Insolation to latest release r=valeriabarra a=valeriabarra ## Purpose The purpose of this PR is to update the `compat` entry for Insolation, given its latest release. This should fix compatibility issues downstream in the Coupler ## Todo / Related PRs - [x] This is blocking this Coupler PR CliMA/ClimaCoupler.jl#306 ## Content - Updated Insolation compat entry in the top-level Project.toml file - Applied necessary API changes Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. - [x] I have read and checked the items on the review checklist. Co-authored-by: Valeria Barra <[email protected]> Co-authored-by: Charles Kawczynski <[email protected]>
valeriabarra
force-pushed
the
valeria/atmos-v0.12
branch
from
96360ca
to
35cf8be
Compare
valeriabarra
changed the title
This was referenced May 23, 2023
valeriabarra
force-pushed
the
valeria/atmos-v0.12
branch
2 times, most recently
from
54e4f70
to
74f3f17
Compare
valeriabarra
changed the title
valeriabarra
force-pushed
the
valeria/atmos-v0.12
branch
from
369b175
to
53d7ad8
Compare
valeriabarra
force-pushed
the
valeria/atmos-v0.12
branch
4 times, most recently
from
71a4d24
to
97dbb84
Compare
valeriabarra
force-pushed
the
valeria/atmos-v0.12
branch
from
97dbb84
to
a3e0a79
Compare
valeriabarra
force-pushed
the
valeria/atmos-v0.12
branch
from
f063fd9
to
3a75c06
Compare
This was referenced Jun 16, 2023
bors bot
added a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
Jun 16, 2023
1777: Add SurfaceSetup Field case r=valeriabarra a=valeriabarra ## Purpose The purpose of this PR is to allow SurfaceSetup to also be a Field. We found that this was needed for the Coupler (see PR #[306](CliMA/ClimaCoupler.jl#306)) Closes #1776 ## Content - Added another `ifelse` case in `update_surface_conditions!` Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. ---- - [x] I have read and checked the items on the review checklist. Co-authored-by: Valeria Barra <[email protected]>
LenkaNovak
added
🍃 leaf
valeriabarra
force-pushed
the
valeria/atmos-v0.12
branch
2 times, most recently
from
33806d1
to
87cd7a8
Compare
valeriabarra
changed the title
1 task
LenkaNovak
force-pushed
the
valeria/atmos-v0.12
branch
from
9693bc7
to
81363a7
Compare
LenkaNovak
force-pushed
the
valeria/atmos-v0.12
branch
2 times, most recently
from
f8338d1
to
b3304e0
Compare
Apply ClimaLSM API soil resistance changes Apply ClimaComms API changes; remove ClimaCommsMPI Update ClimaAtmos CLI options Use ClimaAtmos v0.14.1 ClimaAtmos change: rename Y.f.w -> Y.f.u₃ ClimaLSM API change: use make_exp_tendency in place of make_ode_function Use ClimaComms.CPUDevice() Remove simulation.is_distributed from Atmos change PR #1634 WIP: Apply changes from surface fluxes rework CA PR #1447 Rebase onto main after PRs #315 & #320 WIP: update to ClimaAtmos surface rework Co-authored-by: Lenka Novak <[email protected]> TEMP ONLY: Test CA surface setup fix dev branch Adapt flux calculation given CA current Surface Setup Some WIP fixes w/ Lenka Co-authored-by: Lenka Novak <[email protected]> CI: Try Float64 for AMIP modular experiment Increase alloc limit for perf test Update to ClimaAtmos v0.15.0 conserving, need Atmos #1803 test ci with Atmos fix ClimaCore up add refs to TD and CAP init with 0 atmos fluxes Atmos-commit dep perf project test project pip perf Manifest flame fix rm idealinsol true rm idealized insol increase allocs rm debug.jl clean climaatmos_init.jl race condition fix make Float64 default for all Buildkites typo up julia 1.8.5 up julia 1.8.5 rev rev rev eps(FT)
LenkaNovak
force-pushed
the
valeria/atmos-v0.12
branch
from
078b229
to
6f4eabe
Compare
juliasloan25
approved these changes
Jun 26, 2023
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This was referenced Jul 12, 2023
mitraA90
pushed a commit
to CliMA/ClimaLand.jl
that referenced
this pull request
Dec 22, 2023
195: Update Insolation to latest release r=valeriabarra a=valeriabarra ## Purpose The purpose of this PR is to update the `compat` entry for Insolation, given its latest release. This should fix compatibility issues downstream in the Coupler ## Todo / Related PRs - [x] This is blocking this Coupler PR CliMA/ClimaCoupler.jl#306 ## Content - Updated Insolation compat entry in the top-level Project.toml file - Applied necessary API changes Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. - [x] I have read and checked the items on the review checklist. Co-authored-by: Valeria Barra <[email protected]> Co-authored-by: Charles Kawczynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR attempts at updating the Coupler again, with the latest ClimaAtmos release: v0.15.1
Closes #308
Closes #231
Edit: we needed to update
Insolation.jlin ClimaAtmos again (see this blocking PR CliMA/ClimaAtmos.jl#1674). Hence, once that is merged, we will tag new ClimaAtmos releases and then update the Coupler to that directlyTo-do
compatentries in all environmentContent
compatentries in all environmentQA:
Note
repo-rev = "e82764b9229629a4b12954ae8420e54f81a5f321", since we had to implement a fix that allowed prescription of surface fluxes from the coupler. We will update this for the ClimaAtmos0.15.2 tag during the next release cycle.SurfaceStatetype fix ClimaAtmos.jl#1803 introduces a fix for SurfaceState type. This is the functionality needed from the commit ClimaCoupler is currently pinned to. @valeriabarra plans to make a patch release of ClimaAtmos this week (10 July 2023) so we no longer need to pin to a specific commit.Review checklist
I have:
In the Content, I have included
relevant unit tests, and integration tests,
appropriate docstrings on all functions, structs, and modules, and included relevant documentation.
I have read and checked the items on the review checklist.