Add output for debugging TC in CA #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trontrytel
requested review from
charleskawczynski,
szy21,
yairchn and
jiahe23
10 tasks
bors bot
added a commit
that referenced
this pull request
Sep 8, 2022
829: fix allocations for snow and rain output r=trontrytel a=trontrytel # PULL REQUEST This PR fixes some allocations related to outputting rain and snow. See the discussion here: #816 `@charleskawczynski` - Is that what you had in mind? ## Purpose and Content (Clearly and concisely state the purpose of this PR) ## Benefits and Risks (State concisely the benefits to be derived from and the risks associated with this PR) ## Linked Issues (Provide references to any link issues. Use closes #issuenum to automatically close an open issue) - Fixes # - Closes # ## PR Checklist - [ ] This PR has a corresponding issue OR is linked to an SDI. - [ ] I have followed CliMA's codebase [contribution](https://clima.github.io/ClimateMachine.jl/latest/Contributing/) and [style](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) guidelines OR N/A. - [ ] I have followed CliMA's [documentation policy](https://github.com/CliMA/policies/wiki/Documentation-Policy). - [ ] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR. - [ ] I linted my code on my local machine prior to submission OR N/A. - [ ] Unit tests are included OR N/A. - [ ] Code used in an integration test OR N/A. - [ ] All tests ran successfully on my local machine OR N/A. - [ ] All classes, modules, and function contain docstrings OR N/A. - [ ] Documentation has been added/updated OR N/A. Co-authored-by: Anna Jaruga <[email protected]>
bors bot
added a commit
that referenced
this pull request
Sep 8, 2022
829: fix allocations for snow and rain output r=trontrytel a=trontrytel # PULL REQUEST This PR fixes some allocations related to outputting rain and snow. See the discussion here: #816 `@charleskawczynski` - Is that what you had in mind? ## Purpose and Content (Clearly and concisely state the purpose of this PR) ## Benefits and Risks (State concisely the benefits to be derived from and the risks associated with this PR) ## Linked Issues (Provide references to any link issues. Use closes #issuenum to automatically close an open issue) - Fixes # - Closes # ## PR Checklist - [ ] This PR has a corresponding issue OR is linked to an SDI. - [ ] I have followed CliMA's codebase [contribution](https://clima.github.io/ClimateMachine.jl/latest/Contributing/) and [style](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) guidelines OR N/A. - [ ] I have followed CliMA's [documentation policy](https://github.com/CliMA/policies/wiki/Documentation-Policy). - [ ] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR. - [ ] I linted my code on my local machine prior to submission OR N/A. - [ ] Unit tests are included OR N/A. - [ ] Code used in an integration test OR N/A. - [ ] All tests ran successfully on my local machine OR N/A. - [ ] All classes, modules, and function contain docstrings OR N/A. - [ ] Documentation has been added/updated OR N/A. Co-authored-by: Anna Jaruga <[email protected]>
trontrytel
force-pushed
the
aj/tc_diagnostics
branch
from
a6c2bcd
to
c3b4d76
Compare
charleskawczynski
approved these changes
Sep 9, 2022
|
@charleskawczynski , @yairchn - I added a script that plots the final profiles, something akin to the profile plots we had in OG TC. Lets see if it works in the CI, but on my local machine it generates output like this:
Lmk what else can be fixed or how to make it more general :) |
|
Looks like it worked :0 You can check the additional artifact plots for Bomex (compressible and not) in the CI |
trontrytel
force-pushed
the
aj/tc_diagnostics
branch
2 times, most recently
from
a3849d1
to
b1c1c6a
Compare
Co-authored-by: Charles Kawczynski <[email protected]>
trontrytel
force-pushed
the
aj/tc_diagnostics
branch
from
b1c1c6a
to
430b96a
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Purpose and Content
This PR adds output of most of TC aux state from cache. This is done to help with debugging TC simulations in CA. It also adds plots of some TC variables to the buildkite CI
In order to switch on the TC output set the
--debugging_tc trueand choose the output frequency--dt_save_to_disk 5mins. By default the first flag is set to false so it should not negatively affect any performance tests or long simulations.I'm using the existing infrastructure of saving to HDF5 files and just extending it with our cached TC variables. HTH with integrating TC in CA.
lmk if we want to add it to buildkite or if anything should be added/removed from the output list.
Fixes #817
Benefits and Risks
We will know more about what is happening inside TC in CA
PR Checklist