move diffusivity to precomputed quantities #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noted, thanks. I'll rebase the stability dependent version on this branch. |
szy21
changed the title
config/perf_configs/flame_perf_target_prognostic_edmfx_aquaplanet.yml
Outdated
Show resolved
Hide resolved
szy21
force-pushed
the
zs/refactor_vertdiff
branch
from
7458c41
to
661c630
Compare
dennisYatunin
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Moves the diffusivity calculation to precomputed quantities. Also modifies the vertical diffusion of horizontal momentum. This will help unify the idealized vertical diffusion and edmf diffusion, and the implicit solver. cc @akshaysridhar
co-authored-by: @dennisYatunin
To-do
Content