Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implict solver for diagnostic EDMF #2402

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Add implict solver for diagnostic EDMF #2402

merged 1 commit into from
Dec 2, 2023

Conversation

dennisYatunin
Copy link
Member

@dennisYatunin dennisYatunin commented Dec 1, 2023

Purpose

This PR extends #2379 to diagnostic EDMF.

Content

  • Move the diffusion of TKE into the edmfx_sgs_diffusive_flux_tendency!.
  • Move the edmfx_sgs_diffusive_flux_tendency! into the implicit tendency when implicit_diffusion is true.
  • Add the diffusion matrix for TKE to the Jacobian, and simplify how the diffusion matrix for ρe_tot is set. In addition, add an advection matrix for TKE to the Jacobian, but set this matrix to 0 since the advection of TKE is not currently implicit.
  • Add a new config option approximate_linear_solve_iters for setting the number of iterations of the linear solver when implicit_diffusion is true. The default value for this option is 1.
  • Update the diagnostic EDMF examples in the pipeline so that they set implicit_diffusion to true. Most of these also require setting approximate_linear_solve_iters to 2 in order to produce reasonable results.

  • I have read and checked the items on the review checklist.

@szy21
Copy link
Member

szy21 commented Dec 1, 2023

Thanks for the assert which shows a few mistakes in the current config files:) Fixing them here: #2403

@szy21 szy21 enabled auto-merge December 2, 2023 02:35
@szy21 szy21 added this pull request to the merge queue Dec 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2023
@szy21 szy21 added this pull request to the merge queue Dec 2, 2023
Merged via the queue into main with commit af8e2da Dec 2, 2023
9 of 10 checks passed
@szy21 szy21 deleted the dy/implicit_edmf branch December 2, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants