Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instantaneous zenith angle function #2358

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Update instantaneous zenith angle function #2358

merged 2 commits into from
Nov 21, 2023

Conversation

sriharshakandala
Copy link
Member

@sriharshakandala sriharshakandala commented Nov 13, 2023 •
edited
Loading

Purpose

Update instantaneous zenith angle function to use fixed orbital parameters.

  • I have read and checked the items on the review checklist.

@sriharshakandala sriharshakandala mentioned this pull request Nov 13, 2023
Closed
1 task
@sriharshakandala
Copy link
Member Author

Please see https://buildkite.com/clima/climaatmos-target-gpu-simulations/builds/141#018bc98f-d764-46f6-9fd3-7edae437f3a9 for the GPU pipeline

szy21
szy21 approved these changes Nov 13, 2023
View reviewed changes
src/callbacks/callbacks.jl Show resolved Hide resolved
@sriharshakandala sriharshakandala added the Launch Buildkite Add to launch buildkite run label Nov 13, 2023
@sriharshakandala sriharshakandala force-pushed the sk/update_inst_zenith_ang branch 2 times, most recently from 3661ea4 to d134931 Compare November 14, 2023 06:10
@sriharshakandala sriharshakandala added Launch Buildkite Add to launch buildkite run and removed Launch Buildkite Add to launch buildkite run labels Nov 14, 2023
@sriharshakandala sriharshakandala added Launch Buildkite Add to launch buildkite run and removed Launch Buildkite Add to launch buildkite run labels Nov 14, 2023
@sriharshakandala sriharshakandala added the Launch Buildkite Add to launch buildkite run label Nov 14, 2023
@sriharshakandala
Copy link
Member Author

These seems to be internal Float32 to Float64 conversions in the RRTMGP interface code! This needs to be fixed!

@sriharshakandala sriharshakandala removed the Launch Buildkite Add to launch buildkite run label Nov 14, 2023
@sriharshakandala sriharshakandala added the Launch Buildkite Add to launch buildkite run label Nov 14, 2023
@juliasloan25 juliasloan25 mentioned this pull request Nov 18, 2023
Closed
@sriharshakandala sriharshakandala force-pushed the sk/update_inst_zenith_ang branch 2 times, most recently from f65e27e to 53c66b9 Compare November 20, 2023 18:19
@sriharshakandala sriharshakandala added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit 765bbda Nov 21, 2023
9 of 10 checks passed
@sriharshakandala sriharshakandala deleted the sk/update_inst_zenith_ang branch November 21, 2023 01:09
Sbozzolo pushed a commit that referenced this pull request Nov 21, 2023
@sriharshakandala @Sbozzolo
Merge pull request #2358 from CliMA/sk/update_inst_zenith_ang
a730356 
Update instantaneous zenith angle function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaysridhar akshaysridhar akshaysridhar left review comments

@szy21 szy21 szy21 approved these changes

Assignees
No one assigned
Labels
Launch Buildkite Add to launch buildkite run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sriharshakandala @szy21 @akshaysridhar