Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Nuxt doc #481

Merged
merged 9 commits into from
Jan 13, 2025
Merged

Improve Nuxt doc #481

merged 9 commits into from
Jan 13, 2025

Conversation

maximepvrt
Copy link
Contributor

Describe your PR

I will finish after my PR to add a page on the official nuxt doc nuxt/nuxt.com#1668

Checklist

Reviewers

Who should review these changes? @CleverCloud/reviewers

@github-actions GitHub Actions
Copy link

You updated . This content is also listed on external doc. Issue number has been created and assigned to you 🫵👁️👄👁️

See it or modify it here:
*

This unique comment uses the very cool taoliujun/action-unique-comment. Thank you <3

@github-actions GitHub Actions
Copy link

Deployment has finished 👁️👄👁️ Your app is available here

@maximepvrt
Copy link
Contributor Author

@juliamrch

@cnivolle
Copy link
Member

cnivolle commented Jan 7, 2025

Hello @maximepvrt,
Julia is away for a few daysn we'll head back to you in a couple of days.

@github-actions GitHub Actions
Copy link

🚀 You updated your review app. Check it here

juliamrch
juliamrch previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@juliamrch juliamrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maximepvrt ! Thank you very much for the suggestion on Nuxt doc. I fixed some sentences to add clarity according to our editorial style guide, and a question about the guide, but overall this can be merged as it is.

content/guides/nuxt.md Outdated Show resolved Hide resolved
content/guides/nuxt.md Outdated Show resolved Hide resolved
content/guides/nuxt.md Outdated Show resolved Hide resolved
content/guides/nuxt.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

🚀 You updated your review app. Check it here

1 similar comment
@github-actions GitHub Actions
Copy link

🚀 You updated your review app. Check it here

juliamrch
juliamrch reviewed Jan 13, 2025
View reviewed changes
content/guides/nuxt.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

🚀 You updated your review app. Check it here

@github-actions GitHub Actions
Copy link

🚀 You updated your review app. Check it here

@juliamrch juliamrch merged commit 249bd11 into CleverCloud:main Jan 13, 2025
3 checks passed
@github-actions GitHub Actions
Copy link

You closed this PR and deleted the review app 👋

@juliamrch juliamrch self-assigned this Jan 13, 2025
@maximepvrt
Copy link
Contributor Author

@juliamrch Could you review nuxt/nuxt.com#1668? It's based on the https://docs.astro.build/fr/guides/deploy/clever-cloud/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliamrch juliamrch juliamrch approved these changes

Assignees

@juliamrch juliamrch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximepvrt @cnivolle @juliamrch