chore: prettier format test #1031
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this preview branch, it really helps! Overall, I'm really looking forward the benefits of this tool, although some rules are meh but we'll be able to adjust them over time. Random feedback:
|
florian-sanders-cc
force-pushed
the
master
branch
from
41216d6
to
9079380
Compare
florian-sanders-cc
added
enhancement
feedback ADR Florian and Pierre
Galimede
force-pushed
the
formatter-update-lookup
branch
from
458329f
to
7427292
Compare
pdesoyres-cc
approved these changes
Jul 3, 2024
.prettierignore
Outdated
| **/*.md | ||
|
|
||
| # Ignore stories | ||
| #src/components/*/*.stories.js |
There was a problem hiding this comment.
I'm in favor of that: We should not ignore stories
There was a problem hiding this comment.
Let's add them (even if it makes them a bit more verbose)
Galimede
force-pushed
the
formatter-update-lookup
branch
from
ec016e7
to
8a37905
Compare
florian-sanders-cc
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.