Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add custom retention periods for data #892

Merged
merged 3 commits into from
Nov 13, 2022

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Nov 13, 2022

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Allows for custom data retention ranges by setting either --retention or the retention field in the config flags. This supports a human-readable time (e.g. 5m, 1d).

Issue

If applicable, what issue does this address?

Closes: #239

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2022

Codecov Report

Base: 18.43% // Head: 18.50% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (77cdfee) compared to base (97bf8bf).
Patch coverage: 63.15% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
+ Coverage   18.43%   18.50%   +0.07%     
==========================================
  Files          74       74              
  Lines       13798    13820      +22     
==========================================
+ Hits         2543     2558      +15     
- Misses      11255    11262       +7     
Impacted Files Coverage Δ
src/app.rs 0.00% <0.00%> (ø)
src/constants.rs 0.00% <ø> (ø)
src/bin/main.rs 37.43% <33.33%> (ø)
src/options.rs 42.66% <69.09%> (+0.14%) ⬆️
src/clap.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang merged commit 5076890 into master Nov 13, 2022
@ClementTsang ClementTsang deleted the custom_retention_periods branch November 13, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Longer and/or configurable data retention ranges
2 participants