Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PgUp and PgDown in the help dialog. #841

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

lroobrou
Copy link
Contributor

Description

The PageUp and PageDown keys weren't doing anything in the help dialog, so I added some lines to make them work.

Issue

Easier navigation in the help dialog.

Testing

I ran cargo test after my changes. For the behavior of the keys themselves, I tested it manually.

  • [ ] Windows
  • [ ] macOS
  • [ x ] Linux

Checklist

  • [ x ] Areas your change affects have been linted using rustfmt (cargo fmt)
  • [ x ] The change has been tested and doesn't appear to cause any unintended breakage
  • [ ] Documentation has been added/updated if needed (README.md, help menu, etc.)
  • [ ] The pull request passes the provided CI pipeline
  • [ x ] There are no merge conflicts
  • [ ] If relevant, new tests were added (don't worry too much about coverage)

@codecov-commenter
Copy link

Codecov Report

Base: 18.82% // Head: 18.81% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (1ca5d27) compared to base (b879c36).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
- Coverage   18.82%   18.81%   -0.02%     
==========================================
  Files          74       74              
  Lines       13495    13504       +9     
==========================================
  Hits         2541     2541              
- Misses      10954    10963       +9     
Impacted Files Coverage Δ
src/app.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@ClementTsang ClementTsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on my Macbook.

@ClementTsang
Copy link
Owner

@all-contributors please add @lroobrou for code.

@allcontributors
Copy link
Contributor

@ClementTsang

I've put up a pull request to add @lroobrou! 🎉

@ClementTsang ClementTsang merged commit ee2f6c7 into ClementTsang:master Oct 20, 2022
ClementTsang added a commit that referenced this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants