refactor: remove heim network usage #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementTsang
force-pushed
the
remove_heim
branch
2 times, most recently
from
03e6682 to
4c42049
Compare
Codecov ReportBase: 18.82% // Head: 19.27% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #833 +/- ##
==========================================
+ Coverage 18.82% 19.27% +0.44%
==========================================
Files 71 71
Lines 13500 13460 -40
==========================================
+ Hits 2541 2594 +53
+ Misses 10959 10866 -93
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ClementTsang
force-pushed
the
remove_heim
branch
from
4c42049 to
d1c2dda
Compare
ClementTsang
changed the title
ClementTsang
force-pushed
the
remove_heim
branch
from
d1c2dda to
2fc5839
Compare
ClementTsang
force-pushed
the
remove_heim
branch
from
2fc5839 to
415258c
Compare
ClementTsang
added a commit
that referenced
this pull request
Oct 15, 2022
This reverts commit 913562e.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:
heim-rs is currently unmaintained and has various issues with things like dependencies. While I could fork + publish a fork with fixes, it seems easier to just unify our data sources to
sysinfo+ custom implementations anyways.This first commit removes getting network data from heim.
Issue
If applicable, what issue does this address?
Part of: #812
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, etc.)