-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for FreeBSD #766
Conversation
It doesn't work though as sysinfo doesn't make the device name available.
Actual I/O stats still aren't populated though as there's not an easy source for them.
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
==========================================
- Coverage 24.26% 24.12% -0.15%
==========================================
Files 57 60 +3
Lines 12907 12982 +75
==========================================
Hits 3132 3132
- Misses 9775 9850 +75
Continue to review full report at Codecov.
|
Finally got some time to look at it, looks good to me. I tested compilation/running on Windows and it works fine too. I'll add CI for testing/building FreeBSD in a separate PR when I have some time. |
@all-contributors please add @wezm for code |
I've put up a pull request to add @wezm! 🎉 |
Description
Adds support for running
bottom
on FreeBSD.Notes
sysinfo
and some FreeBSD specific code.sysinfo
makes this information available at this time.serde_json
is added for FreeBSD targets as this code makes use of the ability for some commands in the FreeBSD base system to emit machine readable output in JSON via the libxo library.Issue
Closes: #480
Testing
I ran this branch of the code on FreeBSD (amd64) and Linux (x86_64). I Checked that it compiles for x86_64 macOS (
cargo check --target x86_64-apple-darwin
). I have not tested Windows as I do not use it.Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, etc.)