Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to another arrow. #46

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Switch to another arrow. #46

merged 1 commit into from
Feb 27, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Feb 27, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Switches the character we used for arrows from ⯆⯅ to ▼▲

Seems like the old one caused rendering issues for macOS (at least for me). Could have been a font issue or something, but this fixes it (again, at least for me).

image

Issue

If applicable, what issue does this address?

Closes: #45
Potentially #42

Type of change

Remove the irrelevant one:

  • Bug fix (non-breaking change which fixes an issue)

Test methodology

Please state how this was tested:

Tested whether the arrow shows on Konsole, Terminator, and Kitty on Arch Linux.

Tested on macOS Catalina with Terminal and Kitty.

Checklist

Please ensure all are ticked (and actually done):

  • Change has been tested to work
  • Code has been linted using rustfmt
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced
  • Documentation has been added/updated if needed

Other information

Provide any other relevant information:

@ClementTsang ClementTsang merged commit e5957e0 into master Feb 27, 2020
@ClementTsang ClementTsang deleted the investigate_arrow_problem branch February 27, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow icon looks strange on kitty terminal on macOS Catalina
1 participant