Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Add decimal to actual memory usage in proc #449

Merged
merged 3 commits into from
Apr 9, 2021

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Apr 9, 2021

Description

A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:

This change adds a decimal + single digit to memory usage in the process widget. Note that this only affects all cases where the value is less than 0.05, so we don't have 0.0B displayed. Otherwise, it's a fairly straightforward change.

This change adds a decimal + single digit to memory usage values over the 1 GiB threshold. Otherwise, there is no visible change.

(Note to self: implement the per-column width system soon, this change causes some values to potentially look a bit weird in mem-non-percent mode as it is if the value is really large, like 530.2GiB pushing right up against the column width, but it's currently tied to mem-percent mode. Ugh.)

Also revert a change made by accident where I switched to a decimal prefix system (GB) for memory values. This has been reverted back to a binary prefix (GiB).

image

Issue

If applicable, what issue does this address?

Closes: #448

Type of change

Remove the irrelevant ones:

  • Other (something else - please specify) Small change to add a decimal place to memory usage values

Test methodology

If relevant, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

If relevant, all of these platforms should be tested.

Checklist

If relevant, ensure the following have been met:

  • Change has been tested to work, and does not cause new breakage unless intended
  • Code has been self-reviewed
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • Passes CI pipeline (clippy check and cargo test check)
  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information to this change:

Also revert a change made by accident where I switched to a decimal
prefix system for memory values.  This has been reverted back to a
binary prefix.
@ClementTsang ClementTsang merged commit edb29a4 into master Apr 9, 2021
@ClementTsang ClementTsang deleted the add_decimals_to_proc_mem branch April 9, 2021 19:43
ClementTsang added a commit that referenced this pull request Apr 9, 2021
A bit of a followup to #449, this adds decimal places for values over 1GB in regards to disk usage. This affects the disk widget (for the read/write per second) and process widgets (total read, total write, read/write per second).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add decimal digit to a process memory representation when it's in GiB
1 participant