Fix unicode #43
Merged
Fix unicode #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cursor movement in search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change and what it does. If relevant, please provide screenshots of what results from the change:
Fixes unicode characters in search causing a crash.
Issue
If applicable, what issue does this address?
Closes: #33
Type of change
Remove the irrelevant one:
Test methodology
Please state how this was tested:
Tested on Arch Linux, Kitty. Used a variety of unicode characters, CJK, and normal ASCII, and tested backspace, delete, cursor movement, and adding characters.
Tested on macOS Catalina on Terminal. See above.
Checklist
Please ensure all are ticked (and actually done):
Other information
Provide any other relevant information:
Commit also contains some irrelevant commits to change some github file formats and README.