Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix inconsistent spacing with grouped vs non-grouped in the process widget #416

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Feb 18, 2021

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Fixes grouped mode having different spacing than non-grouped mode.

Video below compares the fixed version (first one) to the release version (0.5.7):

bottom.sort.count.spacing.fix.mp4

Issue

If applicable, what issue does this address?

Closes: #415

Type of change

Remove the irrelevant ones:

  • Bug fix (non-breaking change which fixes an issue)

Test methodology

If relevant, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

If relevant, all of these platforms should be tested.

Checklist

If relevant, ensure the following have been met:

  • Change has been tested to work, and does not cause new breakage unless intended
  • Code has been self-reviewed
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • Passes CI pipeline (clippy check and cargo test check)
  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information to this change:

@ClementTsang ClementTsang changed the title bug: fix inconsistent spacing with grouped vs non-grouped modes bug: fix inconsistent spacing with grouped vs non-grouped modes in the process widget Feb 18, 2021
@ClementTsang ClementTsang changed the title bug: fix inconsistent spacing with grouped vs non-grouped modes in the process widget bug: fix inconsistent spacing with grouped vs non-grouped in the process widget Feb 18, 2021
@ClementTsang ClementTsang merged commit e6230ef into master Feb 19, 2021
@ClementTsang ClementTsang deleted the fix_count_spacing branch February 19, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird column interaction when sorting processes by count
1 participant