Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix hide table gap option not working in battery widget #386

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jan 6, 2021

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Fixes the hide_table_gap option not working with the battery widget.

Example now:

cargo r -- --battery:
image

cargo r -- --battery --hide_table_gap
image

Issue

If applicable, what issue does this address?

Closes: #385

Type of change

Remove the irrelevant ones:

  • Bug fix (non-breaking change which fixes an issue)

Test methodology

If relevant, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

If relevant, all of these platforms should be tested.

Checklist

If relevant, ensure the following have been met:

  • Change has been tested to work, and does not cause new breakage unless intended
  • Code has been self-reviewed
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • Passes CI pipeline (clippy check and cargo test check)
  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information to this change:

@ClementTsang ClementTsang merged commit cfddb7e into master Jan 6, 2021
@ClementTsang ClementTsang deleted the fix_table_gap_in_battery branch January 6, 2021 03:18
ClementTsang added a commit that referenced this pull request Jan 6, 2021
@cooperuser
Copy link

Can confirm that it is working on macOS, though I would have been surprised if it wasn't. I'm just happy to be able to help filling those checkboxex. ✅

image

@ClementTsang ClementTsang mentioned this pull request Jan 25, 2021
10 tasks
ClementTsang added a commit that referenced this pull request Jan 31, 2021
Fixes the `hide_table_gap` option not working with the battery widget.

(cherry picked from commit cfddb7e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Battery display does not follow hide_table_gap configuration
2 participants