Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Use correct labels for sensors in Linux #215

Merged
merged 3 commits into from
Sep 1, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Aug 31, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Update temperature sensors in Linux to use labels + names rather than just names.

Note that this change does cause some of the names to be rather large... for example, the sensor known before as edge is now amdgpu: edge. I plan to address this later since I want to rewrite how column widths are done.

Issue

If applicable, what issue does this address?

Closes: #

Type of change

Remove the irrelevant ones:

  • Bug fix (non-breaking change which fixes an issue)

Test methodology

If required, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, see if the following have been met:

  • Change has been tested to work
  • Areas your change affects have been linted using rustfmt
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced unless intended
  • Passes CI tests
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information:

Update temperature sensors in Linux to use labels rather than names
@ClementTsang ClementTsang merged commit 5ed5731 into master Sep 1, 2020
@ClementTsang ClementTsang deleted the fix_temperature_labels_linux branch September 1, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant