Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies 2020-08-08, drop MSRV #181

Merged
merged 14 commits into from
Aug 12, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Aug 11, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Update dependencies to most recent versions if applicable. Refactor to deal with breaking changes. Drop MSRV due to dependency issues, just support stable and later.

Issue

If applicable, what issue does this address?

Closes: #

Type of change

Remove the irrelevant ones:

  • Other (something else - please specify if relevant)

Test methodology

If required, please state how this was tested:

The main point that might have broken is the text alignments, due to the tui-rs update having breaking changes. As such, most of the tests are focused on this.

  • Test general look
  • Test help
  • Test dd
  • Test basic
  • Test battery

Furthermore, there was a sysinfo update, so check those...

  • Test sysinfo on Linux
  • Test sysinfo on macOS
  • Test sysinfo on Windows

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, see if the following have been met:

  • Change has been tested to work
  • Areas your change affects have been linted using rustfmt
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced unless intended
  • Passes CI tests
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information:

@ClementTsang ClementTsang changed the title Update dependencies 2020 08 08 Update dependencies 2020-08-08 Aug 11, 2020
@ClementTsang ClementTsang marked this pull request as ready for review August 11, 2020 19:46
@ClementTsang ClementTsang changed the title Update dependencies 2020-08-08 Update dependencies 2020-08-08, drop MSRV Aug 11, 2020
@ClementTsang ClementTsang merged commit d0cc607 into master Aug 12, 2020
@ClementTsang ClementTsang deleted the update_dependencies_2020_08_08 branch August 12, 2020 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant