Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill dialog: vim navigation #134

Merged

Conversation

andys8
Copy link
Contributor

@andys8 andys8 commented Apr 28, 2020

Description

Add hjkl as navigation keys in kill dialog.

Issue

Closes #133

Type of change

Remove the irrelevant ones:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (if this change causes breakage or new behaviour, please state what):
  • Other (something else - please specify if relevant):

Test methodology

Please state how this was tested:

The dialog

Please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

Checklist

Please ensure all are ticked (and actually done):

  • Change has been tested to work
  • Areas your change affects have been linted using rustfmt
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced unless intended
  • Documentation has been added/updated if needed
  • No merge conflicts arise from the change

Other information

Provide any other relevant information:

src/app.rs Outdated Show resolved Hide resolved
@andys8 andys8 force-pushed the feature/kill-dialog-vim-navigation branch from 9faf544 to 77ca506 Compare April 28, 2020 20:52
Add `hjkl` as navigation keys in kill dialog.

Closes ClementTsang#133
@andys8 andys8 force-pushed the feature/kill-dialog-vim-navigation branch from 77ca506 to eb0b372 Compare April 28, 2020 20:57
@andys8 andys8 requested a review from ClementTsang April 28, 2020 21:03
@ClementTsang ClementTsang merged commit e850d3d into ClementTsang:master Apr 28, 2020
@ClementTsang
Copy link
Owner

@all-contributors add @andys8 for code

@allcontributors
Copy link
Contributor

@ClementTsang

I've put up a pull request to add @andys8! 🎉

ClementTsang added a commit that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vim navigation in confirm kill dialog
2 participants