Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: pin serde to <=1.0.171 #1278

Merged
merged 1 commit into from
Aug 19, 2023
Merged

deps: pin serde to <=1.0.171 #1278

merged 1 commit into from
Aug 19, 2023

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Aug 19, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

See: serde-rs/serde#2538

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang marked this pull request as ready for review August 19, 2023 19:45
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (54c7fe5) 31.66% compared to head (fb6b141) 31.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1278   +/-   ##
=======================================
  Coverage   31.66%   31.66%           
=======================================
  Files          98       98           
  Lines       16669    16669           
=======================================
  Hits         5279     5279           
  Misses      11390    11390           
Flag Coverage Δ
macos-12 33.42% <ø> (ø)
ubuntu-latest 33.25% <ø> (ø)
windows-2019 33.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang merged commit ea6f87f into master Aug 19, 2023
@ClementTsang ClementTsang deleted the pin_serde_1.0.171 branch August 19, 2023 20:06
@joshsleeper
Copy link

@ClementTsang fwiw the precompiled binary change that caused all that huff was actually reverted in the 1.0.184 release after much debate.

https://github.com/serde-rs/serde/releases/tag/v1.0.184

@ClementTsang
Copy link
Owner Author

Thanks for the heads up - I'm well aware of the development, and I might revert/pin to a version post-change later.

@mo8it mo8it mentioned this pull request Aug 26, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants