Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full width battery bar #1251

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

gabelluardo
Copy link
Contributor

@gabelluardo gabelluardo commented Jul 9, 2023

Description

Add full width bar in battery widget with spacing between charge info e battery info

immagine
immagine

Issue

Closes: #1238

Testing

  • Windows
  • macOS
  • Linux

Checklist

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (ccc7091) 31.84% compared to head (414d72d) 31.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
- Coverage   31.84%   31.82%   -0.03%     
==========================================
  Files          97       97              
  Lines       16581    16594      +13     
==========================================
  Hits         5281     5281              
- Misses      11300    11313      +13     
Flag Coverage Δ
macos-12 33.42% <0.00%> (-0.03%) ⬇️
ubuntu-latest 33.42% <0.00%> (-0.03%) ⬇️
windows-2019 33.66% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/canvas/widgets/battery_display.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang self-assigned this Jul 9, 2023
@ClementTsang
Copy link
Owner

LGTM, will merge this in a bit. Thanks!

@ClementTsang
Copy link
Owner

@all-contributors please add @gabelluardo for code.

@allcontributors
Copy link
Contributor

@ClementTsang

I've put up a pull request to add @gabelluardo! 🎉

@ClementTsang ClementTsang merged commit 83a8607 into ClementTsang:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase size of the "Charge %" bar in the battery widget
2 participants