Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lockfiles, and update parcel/core #58

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Conversation

michaellisitsa
Copy link
Contributor

@michaellisitsa michaellisitsa commented Jan 29, 2025

@michaellisitsa michaellisitsa marked this pull request as draft January 29, 2025 00:24
@michaellisitsa
Copy link
Contributor Author

Outstanding:

  • merge conflict
  • Running npm run compile-interactive has issues Cannot find module "@parcel/config-default", did you mean "@parcel/bundler-default"?

@michaellisitsa michaellisitsa marked this pull request as ready for review January 29, 2025 00:32
@michaellisitsa
Copy link
Contributor Author

Now ready to review. Manual testing completed.

Running npm run compile-interactive has issues Cannot find module "@parcel/config-default", did you mean "@parcel/bundler-default"?

We are using config-default inside of the .parcelrc file, but it is not an explicit import. See similar issue parcel-bundler/parcel#5603 (comment)

@michaellisitsa michaellisitsa merged commit 0bc4527 into main Jan 29, 2025
@michaellisitsa michaellisitsa deleted the add-lockfiles-to-repo branch January 29, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants