Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forestry support #57

Merged
merged 17 commits into from
Jun 24, 2023
Merged

Forestry support #57

merged 17 commits into from
Jun 24, 2023

Conversation

Testure
Copy link
Contributor

@Testure Testure commented May 21, 2023

Includes support for all machines (except bottler because bottler is schizophrenic) plus bee mutations and bee products.

WaitingIdly
WaitingIdly requested changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@WaitingIdly WaitingIdly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • noted down a bunch of non-validated variables that look like they should be validated (eg via msg.add(time < 0, "time must be a nonnegative integer, yet it was {}", time);)
  • can you add an examples script so these changes can be easily tested?

src/main/java/com/cleanroommc/groovyscript/brackets/SpeciesBracketHandler.java Outdated Show resolved Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/forestry/Forestry.java Show resolved Hide resolved
src/main/java/com/cleanroommc/groovyscript/brackets/SpeciesBracketHandler.java Show resolved Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/forestry/Centrifuge.java Show resolved Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/forestry/Centrifuge.java Outdated Show resolved Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/forestry/Fermenter.java Show resolved Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/forestry/Moistener.java Show resolved Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/forestry/Squeezer.java Show resolved Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/forestry/Still.java Show resolved Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/forestry/Still.java Outdated Show resolved Hide resolved
@brachy84 brachy84 added the mod compat Relating to compatability with a mod or features of a mod label Jun 24, 2023
@brachy84 brachy84 merged commit 873de5a into CleanroomMC:master Jun 24, 2023
@Testure Testure deleted the bees branch June 28, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brachy84 brachy84 brachy84 approved these changes

@WaitingIdly WaitingIdly WaitingIdly approved these changes

Assignees
No one assigned
Labels
mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Testure @WaitingIdly @brachy84