added lightningcraft compat #283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New WR adding a gs compat
Rongmario
reviewed
Dec 22, 2024
src/main/java/com/cleanroommc/groovyscript/compat/mods/ModSupport.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/lightningcraft/Infusion.java
Show resolved
Hide resolved
WaitingIdly
requested changes
Dec 22, 2024
src/main/java/com/cleanroommc/groovyscript/compat/mods/lightningcraft/Crusher.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/lightningcraft/Crusher.java
Outdated
Show resolved
Hide resolved
| public static class RecipeBuilder extends AbstractRecipeBuilder<LightningInfusionRecipe> { | ||
|
|
||
| @Property(comp = @Comp(gte = 0)) | ||
| private int le = -1; |
There was a problem hiding this comment.
add defaultValue = "-1" to the annotation
| if (!validate()) return null; | ||
|
|
||
|
|
||
| Object centerItem = input.get(0).getMatchingStacks()[0]; |
There was a problem hiding this comment.
i think this might deserve to be split off into a separate field
There was a problem hiding this comment.
I originally had it as a separate field, but really it has the same treatment as other inputs, and the only difference is that it's a separate argument for the infusion table recipe record
|
I've heard the LC's own lightning transform is really buggy (see: DJ2 where you can only craft electricium in a specific order), which is why I haven't implemented it. Do not mind trying to implement lightning transform properly under in-world crafting. |
brachy84
added
the
mod compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
literally no one asked for this but here we go
oh wait Lord_Chaos did