Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Future MC compat #254

Merged
merged 3 commits into from
Oct 6, 2024
Merged

add Future MC compat #254

merged 3 commits into from
Oct 6, 2024

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • adds Future MC stonecutter, smithing, campfire, blastFurnace, and smoking compat. adds examples and i18n for those.

@WaitingIdly WaitingIdly added the mod compat Relating to compatability with a mod or features of a mod label Oct 5, 2024
brachy84
brachy84 approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recipes are all very simple. Maybe add simple add(...) methods?

@WaitingIdly
Merge branch 'master' into future-mc
efa6769 
# Conflicts:
#	src/main/java/com/cleanroommc/groovyscript/compat/mods/ModSupport.java
@WaitingIdly
fix imports
751eafc
@brachy84 brachy84 merged commit 599a59e into CleanroomMC:master Oct 6, 2024
@WaitingIdly WaitingIdly deleted the future-mc branch October 6, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees
No one assigned
Labels
mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaitingIdly @brachy84