-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Edge Case Running Status of Sandbox #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that,
src/main/java/com/cleanroommc/groovyscript/sandbox/GroovyScriptSandbox.java
Outdated
Show resolved
Hide resolved
Wtf? How does that fix your issue? |
Fixing review comment now. I believe the fix still works with the proper fix, but will recheck. |
Its closures... When they stop running is always set to false |
Breaks for closures... in scripts themselves, outside of event handlers, etc. |
Fix tested, works as intended. |
Essentially, here's why I think this issue occurs: Closures running in scripts are... pretty common. |
This PR fixes edge cases where the running status of the GroovyScript sandbox is reported, falsely, as not running.
Reproduction Case:
This script uses GT just to report the status of the sandbox, but it should work without gt dependency. This was reproduced in an instance with just GroovyScript and its deps, + GT and its deps.
Output of running the above script: