Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current system is flawed:
This removes the sketchy security manager. Instead we
java.io
,java.nio.file
andjava.nio.channels
java.io.File
File()
ctor toGroovyFile()
ctor (the wrapper).The file wrapper resolves the given path to minecraft home path and then checks if the file really is in minecraft home.
Then on each read/write method we check accessability and crash if we cant access.
Just creating the file will not error. Only until you want to read or write the file. Users can check accessibility with
.isAccessible()
orcanRead()
/canWrite()
.exists()
is always safe to call and ignores accessibility.With this we make file blocking future proof (since modern java will remove security manager) without any performance concerns.
Of course there are still ways to bypass this, but being 100% save is not possible anyways.