Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create NamedRegistry, move some logic to be INamed-based #144

Merged
merged 10 commits into from
Mar 25, 2024

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • moves isEnabled from IScriptReloadable to INamed.
  • uses INamed in places where the specificity of IScriptReloadable isnt needed.
  • adds a NamedRegistry, and moves the name/alias code from VirtualizedRegistry to it.
  • makes ForgeRegistryWrapper extend NamedRegistry, allowing it to have the same name logic.
  • makes things that didnt use the reloading functionality of VirtualizedRegistry extend NamedRegistry instead.
  • makes some compat, in particular related to the VanillaModule, use NamedRegistry and reduce code duplication
  • makes reloading not reload the registry for every alias the registry has.

note: IScriptReloadable extends INamed.

@brachy84 brachy84 added the enhancement New feature or request label Mar 22, 2024
@brachy84 brachy84 merged commit 0aaec99 into CleanroomMC:master Mar 25, 2024
@WaitingIdly WaitingIdly deleted the named-registry branch March 25, 2024 20:15
@brachy84 brachy84 added the refactor Something is rewritten label Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Something is rewritten
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants