Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples scripts #138

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • fixes incorrect and inverted logic for the Astral Sorcery Constellation builder
  • fixes errors in examples scripts due to the bracket handler -> game object handler change making anything that presumed minecraft: would be prefixed to the resource location error
  • updates all examples files to use the generated version

Downsides of this change being that bracket handler stuff no longer has examples, and custom comments are gone. This slightly impacts thaumcraft, roots, mekanism, evilcraft, appliedenergistics2, astralsorcery, and significantly impacts woot. This should be resolved via adding the ability to generate documentation of game object handlers, and otherwise improving documentation.

@brachy84 brachy84 merged commit 67fc28f into CleanroomMC:master Mar 14, 2024
@WaitingIdly WaitingIdly deleted the fix-examples branch March 15, 2024 04:22
@brachy84 brachy84 added the documentation Improvements or additions to documentation label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants