Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Calculator compat #134

Merged
merged 15 commits into from
Mar 20, 2024
Merged

add Calculator compat #134

merged 15 commits into from
Mar 20, 2024

Conversation

WaitingIdly
Copy link
Collaborator

what this PR adds:

  • Adds compat for the algorithmSeparator, atomicCalculator, analysingChamber, basicCalculator, conductorMast, extractionChamber, fabricationChamber, flawlessCalculator, glowstoneExtractor, healthProcessor, precisionChamber, processingChamber, reassemblyChamber, redstoneExtractor, restorationChamber, scientificCalculator, starchExtractor, and stoneSeparator. (thats 18!)
  • i18n wiki keys for the above
  • examples file for the above
  • fixes Sonar Core recipes (Calculator, Flux Networks) breaking on reload
  • use mixins to make sure DefinedRecipeHelperMixin uses a CalculatorRecipe instead of a DefaultSonarRecipe.

complications:

  • "TreeHarvest" aka "Sickle" in JEI does not get compat, since that uses a hardcoded harvestLeaves function comparing specific blockstate data. Not possible to configure.
  • the Analysing Chamber is very messed up. Some recipes in JEI dont work, the chances are simply wrong, adding new recipes requires adding a specific number to a slot, and if that number is rolled for that slot the first entry is used. There can be a maximum of 50 items for the first slot. doesnt have CraftTweaker compat for a very good reason.

@WaitingIdly WaitingIdly added the mod compat Relating to compatability with a mod or features of a mod label Feb 29, 2024
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate reviewing. Simple add methods would be nice

@brachy84 brachy84 merged commit 38e841a into CleanroomMC:master Mar 20, 2024
@WaitingIdly WaitingIdly deleted the calculator branch March 20, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants