Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Alchemistry compat #133

Merged
merged 5 commits into from
Mar 14, 2024
Merged

add Alchemistry compat #133

merged 5 commits into from
Mar 14, 2024

Conversation

WaitingIdly
Copy link
Collaborator

what this PR adds:

  • Adds compat for the atomizer, combiner, dissolver, electrolyzer, evaporator, liquifier.
  • i18n wiki keys for the above
  • examples file for the above
  • element game object handler to get the alchemistry element or compound for the given name

something that is not added in this PR:

  • crafttweaker, through native compat, adds Create Element and Create Compound helpers. these are not added in this PR. a TODO is added for these helpers.

note: when testing, i suggest also enabling Draconic Evolution for the Creative Power Source (no way to get power otherwise)

@WaitingIdly WaitingIdly added the mod compat Relating to compatability with a mod or features of a mod label Feb 27, 2024
brachy84
brachy84 requested changes Mar 9, 2024
View reviewed changes
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add simple add methods for those who dont like builders

src/main/java/com/cleanroommc/groovyscript/compat/mods/alchemistry/Atomizer.java Outdated Show resolved Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/alchemistry/Atomizer.java Outdated Show resolved Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/alchemistry/Electrolyzer.java Outdated Show resolved Hide resolved
@brachy84 brachy84 merged commit 4f1ec82 into CleanroomMC:master Mar 14, 2024
@WaitingIdly WaitingIdly deleted the alchemistry branch March 15, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees
No one assigned
Labels
mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaitingIdly @brachy84