feat: add import-export functions for regions #9
Conversation
| /.vscode | ||
| er-save-editor.exe | ||
| fixtures/* |
There was a problem hiding this comment.
Ignores test files
src/main.rs
Outdated
| @@ -94,6 +97,25 @@ impl App { | |||
| } | |||
| } | |||
|
|
|||
| fn save_regions(&mut self, path: PathBuf) { | |||
There was a problem hiding this comment.
Is this using anything in main or can it be moved to the regions vm?
There was a problem hiding this comment.
I moved the view model specific functionality into that scope. Keeping the rest here as it deals with writing.
src/vm/regions.rs
Outdated
|
|
||
| if is_invadeable_region { | ||
| let region = ID_TO_REGION.lock().unwrap()[key]; | ||
| regions_vm.regions.get_mut(®ion).expect("").0 = true; |
There was a problem hiding this comment.
Maybe you can use unwrap() instead of expect("") if no error message is needed.
Aslo maybe split it into two lines to give the .0 a self descriptive name
let (activated, _,_,_) = regions_vm.regions.get_mut(®ion).unwrap();
*activated = true;There was a problem hiding this comment.
I think I should reserve this refactor until later, so we can focus on functionality in this PR.
|
@ClayAmore I discovered a bug in my original implementation where I wasn't correctly using the provided enabled_ids when they are present. I corrected this and DRYed things up here: |
No description provided.