fix prod calculation for random output amounts with catalyst specified #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, appreciate the very nicely done pull request! I won't be able to merge it for a 1.1 release as this code has changed a lot for the internal 2.0 branch and merging it will be a mess. 1.1 releases are basically done as 2.0 is so close. Would you be okay with revisiting this once 2.0 is out? It probably won't be too difficult to adapt it to the new stuff. |
|
I can do that. Any chance I can get access to the 2.0 branch? I can wait otherwise. |
|
Unfortunately not, you can't make a private fork of a public repo for some stupid reason and setting up a separate one is a PITA. |
|
The code this touches changed quite a bit in my fluid temperatures branch. I'll have another look at this once that one is merged. Sorry for the delays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Productivity only applies to amounts above the catalyst amount. When the productivity bar fills, a set of outputs (random or not) is generated and the catalyst amount is subtracted from each output, with a minimum of 0 (no negative outputs). This fixes the calculation of the "proddable amount" - the effective amount of output that prod can apply to.
This behavior was tested using this mod. Compare with expected and actual results in this spreadsheet.
Fixes issue #88.