Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVX-594]: Clarifai YOLOx Model usage as Layout Detection Model #2

Open
wants to merge 2 commits into
base: support_clarifai_model
Choose a base branch
from
Open

[DEVX-594]: Clarifai YOLOx Model usage as Layout Detection Model #2

wants to merge 2 commits into from

Conversation

srikanthbachala20
Copy link

What

Why

  • By default the multimodal loader function utilises the locally downloaded yolox/detectron model to extract layout and process the PDF file leading to increased memory usage and latency.

How

  • Added a new detection class file in utils using the Clarifai Yolox model for layout detection.

mogith-pn
mogith-pn reviewed Jan 23, 2025
View reviewed changes
Copy link

@mogith-pn mogith-pn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some queries from my end.
I assume you did integration testing with data-utils repo and current functionality (using local model) also working fine without any issues.

unstructured/partition/utils/clarifai_yolox.py Show resolved Hide resolved
unstructured/partition/pdf.py Outdated Show resolved Hide resolved
unstructured/partition/utils/clarifai_yolox.py Show resolved Hide resolved
mogith-pn
mogith-pn approved these changes Jan 24, 2025
View reviewed changes
Copy link

@mogith-pn mogith-pn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Great addition.
Make sure to change the model name in the repo once we transfer the ownership of clarifai app.
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogith-pn mogith-pn mogith-pn approved these changes

@sanjaychelliah sanjaychelliah Awaiting requested review from sanjaychelliah

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srikanthbachala20 @mogith-pn