Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVX-301]: Removing internal_only Training Params #231

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[DEVX-301]: Removing internal_only Training Params #231

merged 1 commit into from
Nov 29, 2023

Conversation

sanjaychelliah
Copy link
Contributor

what

  • Removing internal only training params.
  • Removing internal only training model type.
  • Changing pytest test scripts according to it..

sainivedh
sainivedh approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@sainivedh sainivedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sanjaychelliah sanjaychelliah merged commit 0136107 into master Nov 29, 2023
6 checks passed
@sanjaychelliah sanjaychelliah deleted the DEVX-301-Training_params_bug branch November 29, 2023 07:49
@sainivedh sainivedh mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainivedh sainivedh sainivedh approved these changes

@ackizilkale ackizilkale Awaiting requested review from ackizilkale

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanjaychelliah @sainivedh