Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip tests for PRs from Forks #230

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Skip tests for PRs from Forks #230

merged 3 commits into from
Nov 29, 2023

Conversation

sainivedh
Copy link
Contributor

@sainivedh sainivedh commented Nov 28, 2023 •
edited
Loading

Why

  • Due to no access of secrets for external PRs

@sainivedh sainivedh changed the title enable secrets for forks Enable secrets for forks Nov 28, 2023
@sainivedh sainivedh changed the title Enable secrets for forks Skip tests for PRs from Forks Nov 28, 2023
@sainivedh sainivedh marked this pull request as ready for review November 28, 2023 16:30
ackizilkale
ackizilkale approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ackizilkale ackizilkale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sainivedh sainivedh merged commit 4459228 into master Nov 29, 2023
6 checks passed
@sainivedh sainivedh deleted the allow-secrets-from-forks branch November 29, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ackizilkale ackizilkale ackizilkale approved these changes

@josh-tepper josh-tepper Awaiting requested review from josh-tepper

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sainivedh @ackizilkale