Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVX-288] Dataset Upload Status #218

Merged
merged 7 commits into from
Nov 22, 2023
Merged

[DEVX-288] Dataset Upload Status #218

merged 7 commits into from
Nov 22, 2023

Conversation

sainivedh
Copy link
Contributor

@sainivedh sainivedh commented Nov 22, 2023 •
edited
Loading

Why

  • To get statistics of dataset upload process

What

  • Add get_upload_status() which provides insights on upload status

How

  • Using ListDatasetVersionMetricsGroupsRequest endpoint to get the metrics
  • Compare with local and display the results with neat rendering using rich

Tests

  • Manual check of dataset uplods

Classification

Screenshot 2023-11-22 at 5 08 10 PM

Segmentation

Screenshot 2023-11-22 at 5 19 27 PM

Detection

Screenshot 2023-11-22 at 5 20 20 PM

@sainivedh sainivedh marked this pull request as ready for review November 22, 2023 12:28
isaac-chung
isaac-chung reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The display looks nice :)

clarifai/client/dataset.py Outdated Show resolved Hide resolved
clarifai/client/dataset.py Show resolved Hide resolved
clarifai/datasets/upload/utils.py Outdated Show resolved Hide resolved
clarifai/datasets/upload/utils.py Outdated Show resolved Hide resolved
isaac-chung
isaac-chung approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for iterating.

@sainivedh sainivedh merged commit dbdcb49 into master Nov 22, 2023
4 checks passed
@sainivedh sainivedh deleted the DEVX-288-dataset-upload-status branch November 22, 2023 17:46
@sainivedh sainivedh mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaac-chung isaac-chung isaac-chung approved these changes

@ackizilkale ackizilkale Awaiting requested review from ackizilkale

@sanjaychelliah sanjaychelliah Awaiting requested review from sanjaychelliah

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sainivedh @isaac-chung