Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EAGLE-3652] - vLLM example #217

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[EAGLE-3652] - vLLM example #217

merged 1 commit into from
Nov 30, 2023

Conversation

phatvo9
Copy link
Contributor

@phatvo9 phatvo9 commented Nov 22, 2023

No description provided.

@phatvo9 phatvo9 requested a review from ackizilkale November 22, 2023 07:12
ackizilkale
ackizilkale requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@ackizilkale ackizilkale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the examples on the test page?

clarifai/models/model_serving/examples/vllm/example/1/test.py Show resolved Hide resolved
@phatvo9 phatvo9 requested a review from ackizilkale November 28, 2023 07:36
ackizilkale
ackizilkale approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@ackizilkale ackizilkale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@phatvo9 phatvo9 merged commit 4c2022a into master Nov 30, 2023
4 checks passed
@phatvo9 phatvo9 deleted the EAGLE-3652 branch November 30, 2023 10:25
@phatvo9 phatvo9 mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ackizilkale ackizilkale ackizilkale approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phatvo9 @ackizilkale